Skip to content

Bump to Gradle 8.14.5 (from 8.14.4)#11302

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
bdu/gradle-8.14.5
May 7, 2026
Merged

Bump to Gradle 8.14.5 (from 8.14.4)#11302
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
bdu/gradle-8.14.5

Conversation

@bric3
Copy link
Copy Markdown
Contributor

@bric3 bric3 commented May 7, 2026 •
edited
Loading

What Does This Do

Bump Gradle from 8.14.4 to 8.14.5

https://docs.gradle.org/8.14.5/release-notes.html

  • #37048 [8.14 backport] TransformedClassLoader is not thread-safe
  • #37486 [Backport] Excluding dependencies from included builds doesn't work
./gradlew wrapper --gradle-version=8.14.5 --gradle-distribution-sha256-sum 6f74b601422d6d6fc4e1f9a1ab6522f642c2fdcbc15ae33ebd30ba3d7198e854

Hash sources:

@bric3 bric3 requested a review from a team as a code owner May 7, 2026 13:26
@bric3 bric3 requested a review from mcculls May 7, 2026 13:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@bric3 bric3 changed the title build: Bump to Gradle 8.14.5 (from 8.14.4) Bump to Gradle 8.14.5 (from 8.14.4) May 7, 2026
AlexeyKuznetsov-DD
AlexeyKuznetsov-DD approved these changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have more than one place with Gradle :)
but those places not indexed by IDEA:

dd-smoke-tests/vertx-3.4/application/gradle/wrapper/gradle-wrapper.properties
dd-smoke-tests/vertx-4.2/application/gradle/wrapper/gradle-wrapper.properties
dd-smoke-tests/vertx-3.9/application/gradle/wrapper/gradle-wrapper.properties
dd-smoke-tests/vertx-3.9-resteasy/application/gradle/wrapper/gradle-wrapper.properties

@bric3
Copy link
Copy Markdown
Contributor Author

bric3 commented May 7, 2026

Good call, but do we want to upgrade smoke tests in the same PR ?

This PR is for the main build tool, while those are smoke tests. Also, maybe they probably won't follow to Gradle 9.x migration.

@bric3 bric3 enabled auto-merge May 7, 2026 14:56
@AlexeyKuznetsov-DD
Copy link
Copy Markdown
Contributor

AlexeyKuznetsov-DD commented May 7, 2026

Good call, but do we want to upgrade smoke tests in the same PR ?

This PR is for the main build tool, while those are smoke tests. Also, maybe they probably won't follow to Gradle 9.x migration.

@bric3 To be honest I think we should rework those smoke tests to be not a separate standalone projects, but a part of the build.
And I would update all gradles in one shot justt to keep things in-sync

@bric3
Copy link
Copy Markdown
Contributor Author

bric3 commented May 7, 2026

To be honest I think we should rework those smoke tests to be not a separate standalone projects

That would be my first choice, but these projects depend on third party plugins that depends on specific versions maybe older versions. So I'm wary of the burden we'll need to handle just to align the version, while it's not strictly necessary to achieve the smoke tests.

@bric3 bric3 requested a review from a team as a code owner May 7, 2026 15:16
@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels May 7, 2026
sarahchen6
sarahchen6 approved these changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sarahchen6 sarahchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bric3 bric3 added this pull request to the merge queue May 7, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 7, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 7, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-05-07 16:19:03 UTC ℹ️ Start processing command /merge

2026-05-07 16:19:08 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-05-07 18:19:43 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

Possible reasons:

  • some mandatory checkruns are failing:
    • Check pull requests

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 7, 2026
@bric3
Copy link
Copy Markdown
Contributor Author

bric3 commented May 7, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 7, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-05-07 19:33:49 UTC ℹ️ Start processing command /merge

2026-05-07 19:33:54 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-05-07 20:53:37 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 9984682 into master May 7, 2026
573 of 577 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/gradle-8.14.5 branch May 7, 2026 20:53
@github-actions github-actions Bot added this to the 1.63.0 milestone May 7, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD mentioned this pull request May 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarahchen6 sarahchen6 sarahchen6 approved these changes

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bric3 @AlexeyKuznetsov-DD @sarahchen6